Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad exception message generation #297

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Conversation

joshcanhelp
Copy link
Contributor

Exception message was not being parsed properly, leading to the wrong error being thrown. Was using the direct aud property rather than the converted one. The test was setup up improperly as well, leading to it passing incorrectly. Fixed the error message and the test.

Closes #296

@joshcanhelp joshcanhelp added this to the v5-Next milestone Oct 18, 2018
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshcanhelp joshcanhelp merged commit f78da06 into master Oct 30, 2018
@joshcanhelp joshcanhelp deleted the fix-bad-exception-message branch October 30, 2018 19:58
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants