Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication class cleanup and tests #322

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Conversation

joshcanhelp
Copy link
Contributor

Changes

Very minimal functionality changes.

  • Allow null $client_id for Authentication::get_samlp_link(), Authentication::get_samlp_metadata_link(), and Authentication::get_wsfed_link() to use initialized client ID value.
  • Add request parameters to Authentication::get_wsfed_link()
  • Docblock improvements throughout Authentication class, along with TODOs for deprecation and exclusions from code quality scan.

Testing

  • This change adds test coverage

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used.

@joshcanhelp joshcanhelp added this to the 5.4.0 milestone Feb 20, 2019
@joshcanhelp joshcanhelp merged commit fe79a06 into master Feb 21, 2019
@joshcanhelp joshcanhelp deleted the update-authentication-api branch February 21, 2019 15:20
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants