Authentication class cleanup and tests #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Very minimal functionality changes.
$client_id
forAuthentication::get_samlp_link()
,Authentication::get_samlp_metadata_link()
, andAuthentication::get_wsfed_link()
to use initialized client ID value.Authentication::get_wsfed_link()
Authentication
class, along with TODOs for deprecation and exclusions from code quality scan.Testing
Checklist