Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated unused JWKFetcher methods #373

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Deprecated unused JWKFetcher methods #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Helpers/JWKFetcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public function getKeys($jwks_url)
/**
* Fetch x509 cert for RS256 token decoding.
*
* TODO: Deprecate, use $this->getFormatted()
* @deprecated 5.6.0, use $this->getKeys().
damieng marked this conversation as resolved.
Show resolved Hide resolved
*
* @param string $jwks_url URL to the JWKS.
* @param string|null $kid Key ID to use; returns first JWK if $kid is null or empty.
Expand Down Expand Up @@ -151,7 +151,7 @@ protected function requestJwks($jwks_url)
/**
* Get a JWK from a JWKS using a key ID, if provided.
*
* TODO: Deprecate
* @deprecated 5.6.0, use $this->getKeys().
*
* @param array $jwks JWKS to parse.
* @param null|string $kid Key ID to return; returns first JWK if $kid is null or empty.
Expand Down Expand Up @@ -182,7 +182,7 @@ private function findJwk(array $jwks, $kid = null)
/**
* Check if an array within an array has a non-empty first item.
*
* TODO: Deprecate
* @deprecated 5.6.0, not used.
*
* @param array|null $array Main array to check.
* @param string $key Key pointing to a sub-array.
Expand Down