fix: Restore previous behavior of SdkConfiguration::setScope() being nullable #665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR restores previous behavior that allowed SdkConfiguration::setScope() to accept
null
values. In previous versions, setScope() allowednull | string[]
. This was inadvertently changed to only acceptstring[]
in the previous release.This was mistakenly altered during the migration from the previous magic method approach of offering virtual methods for altering configurations, to the PHP 8.0+ syntax and offering concrete methods.
References
Resolves #664
Testing
Run
/vendor/bin/pest
from a local cloned repo, or review the GitHub status checks below.Contributor Checklist