Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore previous behavior of SdkConfiguration::setScope() being nullable #665

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

evansims
Copy link
Member

@evansims evansims commented Oct 24, 2022

Changes

This PR restores previous behavior that allowed SdkConfiguration::setScope() to accept null values. In previous versions, setScope() allowed null | string[]. This was inadvertently changed to only accept string[] in the previous release.

This was mistakenly altered during the migration from the previous magic method approach of offering virtual methods for altering configurations, to the PHP 8.0+ syntax and offering concrete methods.

References

Resolves #664

Testing

Run /vendor/bin/pest from a local cloned repo, or review the GitHub status checks below.

Contributor Checklist

@evansims evansims added this to the 8.3.6 milestone Oct 24, 2022
@evansims evansims marked this pull request as ready for review October 24, 2022 17:45
@evansims evansims requested a review from a team as a code owner October 24, 2022 17:45
@codecov-commenter
Copy link

Codecov Report

Base: 94.35% // Head: 94.35% // No change to project coverage 👍

Coverage data is based on head (4704137) compared to base (d2d8946).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #665   +/-   ##
=========================================
  Coverage     94.35%   94.35%           
- Complexity     1275     1277    +2     
=========================================
  Files            65       65           
  Lines          4231     4231           
=========================================
  Hits           3992     3992           
  Misses          239      239           
Impacted Files Coverage Δ
src/Configuration/SdkConfiguration.php 71.48% <80.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evansims evansims merged commit f9fc28f into main Oct 24, 2022
@evansims evansims deleted the fix/config-set-scope-should-be-nullable branch October 24, 2022 23:50
github-actions bot pushed a commit that referenced this pull request Oct 24, 2022
@evansims evansims mentioned this pull request Oct 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent changes break existing auth0/login configuration
3 participants