fix: Remove redundant Cache getItem() call in Auth0\SDK\Token\Verifier::getKeySet()
#669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$item (although with an empty value) has already been created on line 198: https://github.com/auth0/auth0-PHP/blob/main/src/Token/Verifier.php#L198. We only have to save the value and expiry here. This change will only (try) to get the value of the cache once instead of twice.
|
Good catch, @pkivits-litebit! We'll need to address the scope of |
evansims
changed the title
getItem() call in Auth0\SDK\Token\Verifier::getKeySet()
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
…h0\SDK\Token\Verifier::getKeySet()` (#669) * Remove unnecessary second getItem call $item (although with an empty value) has already been created on line 198: https://github.com/auth0/auth0-PHP/blob/main/src/Token/Verifier.php#L198. We only have to save the value and expiry here. This change will only (try) to get the value of the cache once instead of twice. * fix: Variable scope Co-authored-by: Evan Sims <evan.sims@okta.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$item has already been created on line 198: https://github.com/auth0/auth0-PHP/blob/main/src/Token/Verifier.php#L198. We only have to save the value and expiry here.
This change will only get the value of the cache once instead of twice.