fix: Always store provided state in transient medium
#674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 94.29% // Head: 94.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
============================================
- Coverage 94.29% 94.22% -0.07%
- Complexity 1282 1285 +3
============================================
Files 65 65
Lines 4187 4190 +3
============================================
Hits 3948 3948
- Misses 239 242 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
…um (#674) * fix: Always store provided `state` in transient medium * Test suite fixes; add error handling for odd OpenSSL error in GitHub VM * Bump Ubuntu version on GitHub VM * Update checks.yml * Update checks.yml * Update TokenGenerator.php * Update checks.yml * Update checks.yml * Update checks.yml * Update checks.yml * Update TokenGenerator.php * Test suite fixes and improvements; PHP 8 language feature adoption
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses a bug reported in #673 by @winstoncl in which: if a
statevalue is provided by the host applications upon callinglogin(), it was not being properly stored within the given transient medium for comparison later (upon callingexchange()on the return trip.) This caused anInvalid Stateexception to be raised.References
Resolves #673
Testing
Run
composer testor see GitHub status checks on this PR.Contributor Checklist