fix: Remove redundant token verification step #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansims
added
the
Scope: Bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #742 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1338 1339 +1
===========================================
Files 62 62
Lines 4670 4671 +1
===========================================
+ Hits 4670 4671 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Making some minor unrelated code tweaks to accommodate upstream changes to our CI tooling, so tests will pass. |
|
Please disregard the remaining failing Rector and PHP CS Fixer tests, I need to fix a bug in the CI workflow there. The tests pass fine locally. |
ewanharris
approved these changes
Nov 28, 2023
Merged
evansims
added a commit
that referenced
this pull request
Nov 29, 2023
**Fixed** - fix: Remove redundant token verification step [\#742](#742) ([evansims](https://github.com/evansims))
Merged
evansims
added a commit
that referenced
this pull request
Nov 30, 2023
**Fixed** - fix: Remove redundant token verification step [\#742](#742) ([evansims](https://github.com/evansims))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes a redundant JWT verification step identified in #741. Verification is already performed in the token verifier constructor, so calling its
verify()method afterward is redundant and unnecessary.References
Closes #741.
Testing
No changes to testing were necessary for this change.
Contributor Checklist