Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make necessary calls to GET Partials basis on the promptType #1107

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

ramya18101
Copy link
Contributor

No description provided.

@ramya18101 ramya18101 requested a review from a team as a code owner November 27, 2024 14:40
@ramya18101 ramya18101 changed the title Update ul assets to make only necessary ws events Make necessary calls to GET Partials basis on the promptType Nov 28, 2024
…porarily commented out the ul prompts update testcase.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.68%. Comparing base (be18be8) to head (55701aa).

Files with missing lines Patch % Lines
internal/cli/universal_login_customize.go 63.63% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
- Coverage   71.81%   70.68%   -1.13%     
==========================================
  Files          94       94              
  Lines       13151    13160       +9     
==========================================
- Hits         9444     9302     -142     
- Misses       3153     3312     +159     
+ Partials      554      546       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramya18101 ramya18101 merged commit fc25ffa into main Dec 2, 2024
9 checks passed
@ramya18101 ramya18101 deleted the update-ul-assets branch December 2, 2024 05:18
@duedares-rvj duedares-rvj mentioned this pull request Dec 9, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants