Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the logs view a little bit more compact #248

Merged
merged 6 commits into from
Apr 14, 2021
Merged

Make the logs view a little bit more compact #248

merged 6 commits into from
Apr 14, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 14, 2021 •
edited
Loading

Description

The view of logs was taking too much space by default, therefore requiring the use of a lot of horizontal space.
This PR tries to strike a more balanced approach, reducing the minimum horizontal space to 145 chars.

Screen Shot 2021-04-14 at 18 41 44

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team April 14, 2021 21:33
cyx
cyx approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cyx cyx merged commit 3b99e45 into main Apr 14, 2021
@cyx cyx deleted the logs-compact-view branch April 14, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @cyx