Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the --no-color flag global [CLI-143] #264

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Make the --no-color flag global [CLI-143] #264

merged 1 commit into from
Apr 26, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 26, 2021

Description

This PR makes the --no-color flag global, as it was only previously defined for logs commands. The display logic was updated to take that value into account, and direct uses of the underlying aurora library have been fixed to use the wrapper ansi package instead.

Screen Shot 2021-04-26 at 16 02 43

Screen Shot 2021-04-26 at 16 05 31

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team April 26, 2021 19:16
jfatta
jfatta approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cyx
cyx approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Widcket Widcket merged commit 4b8fcb5 into main Apr 26, 2021
@Widcket Widcket deleted the no-color branch April 26, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Widcket @cyx @jfatta