Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flag issues on apps create and apps update [CLI-146] #269

Merged
merged 4 commits into from
Apr 30, 2021
Merged

Fix flag issues on apps create and apps update [CLI-146] #269

merged 4 commits into from
Apr 30, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 29, 2021

Description

This PR fixes a series of issues whereby the values of some flags passed to apps create and apps update would be lost. The flags affected were --callbacks, --logout-urls, --origins and --web-origins.

Screen Shot 2021-04-28 at 21 39 37

Screen Shot 2021-04-28 at 21 40 11

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team April 29, 2021 00:51
jfatta
jfatta approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work.
thanks

internal/cli/flags.go
@@ -33,6 +33,10 @@ func (f Flag) GetIsRequired() bool {
return f.IsRequired
}

func (f *Flag) IsSet(cmd *cobra.Command) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Widcket Widcket merged commit 457d3ff into main Apr 30, 2021
@Widcket Widcket deleted the fix-apps-url-flags branch April 30, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @jfatta