Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grants string #270

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Grants string #270

merged 3 commits into from
Apr 29, 2021

Conversation

morganelle
Copy link
Contributor

Description

Remove auth0.String call around grants inputs, which was creating a string pointer output in the console when apps create was run with the --grants flag. apps show was not affected, nor was allowing the CLI to set default grants.

Screen Shot 2021-04-29 at 11 58 28 AM

Testing

Tested manually and verified that behavior in the UI remained unchanged.

Screen Shot 2021-04-29 at 2 15 08 PM

Screen Shot 2021-04-29 at 2 18 23 PM

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@morganelle morganelle marked this pull request as ready for review April 29, 2021 21:29
@morganelle morganelle requested a review from Widcket April 29, 2021 21:41
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Widcket Widcket merged commit 0f93aa7 into main Apr 29, 2021
@Widcket Widcket deleted the grants-string branch April 29, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants