Fix cursor escape seqs being written to StdOut [CLI-154] #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
changed the title
jfatta
reviewed
Apr 30, 2021
Add arm64 to the goarch list (#272)
Widcket
force-pushed
the
fix-cursor-escape-sequences
branch
from
605f549 to
7e56131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The spinner library writes the escape sequences to StdOut, so when piping a json output to a file it will contain invalid characters.That bug was fixed on a PR from December 2020 (briandowns/spinner#109), however it remains unreleased.
This PR updates the spinner library to the latest commit on master, to get the fix, and configures the spinner to use StdErr.
Testing
Checklist
master