Integration tests for auth0 apps commands and flags [CLI-95]

[morganelle]

Description

Use Commander to add integration tests for the following commands, with tests for every flag and flag value.

• apps create
• apps update
• apps show

Added two small helper scripts to store an app id for tests that require an existing app as well as a cleanup script to delete the fixtures created during testing.

Also fixed two small typos found during development.

Testing

These updates can be tested by running make integration. Verified that the apps not prefixed with integration-test- were not deleted during test cleanup.

Checklist

• I have added documentation for new/changed functionality in this PR or in auth0.com/docs
• All active GitHub checks for tests, formatting, and security are passing
• The correct base branch is being used, if not master

[rene00]

This test is failing for me due to N being uppercase in contains but lower case in the result:

✗ [local] 'apps create type native and check output', on property 'Stdout'

Expected
[...]
  TYPE                 native
[...]
to contain

TYPE                 Native

Suggested change

	- TYPE Native
	- TYPE native

I can see that we're already testing this command here but this command is the plain format. Have you considered removing this plain format test all together?

[rene00]

✋ Ignore this. Error was on my side. I was running an older version of auth0.

[morganelle]

Removing the plain format tests that duplicate json format tests is a good question, though. I included it in case we want an indication when the formatting changes unexpectedly but it could be fussy to maintain.

[rene00]

perhaps a nitpick here, but we could replace recursive use of make with:

run-integration:
    auth0-cli-config-generator && commander test commander.yaml
.PHONY: run-integration

integration: $(GOBIN)/auth0-cli-config-generator $(GOBIN)/commander run-integration integration-cleanup
.PHONY: integration

[morganelle]

Updated

[rene00]

This an awesome PR and a great step forward for auth0-cli. Nice work 💯

[rene00]

Perhaps an issue on my end but when running make integration I was prompted for device flow auth:

export AUTH0_CLI_CLIENT_NAME="integration" \
    AUTH0_CLI_CLIENT_DOMAIN="REDACTED" \
    AUTH0_CLI_CLIENT_ID="REDACTED" \
    AUTH0_CLI_CLIENT_SECRET="REDACTED" \
    AUTH0_CLI_REUSE_CONFIG="false" \
    AUTH0_CLI_OVERWRITE="true"
make integration

[morganelle]

Perhaps an issue on my end but when running make integration I was prompted for device flow auth:

export AUTH0_CLI_CLIENT_NAME="integration" \
    AUTH0_CLI_CLIENT_DOMAIN="REDACTED" \
    AUTH0_CLI_CLIENT_ID="REDACTED" \
    AUTH0_CLI_CLIENT_SECRET="REDACTED" \
    AUTH0_CLI_REUSE_CONFIG="false" \
    AUTH0_CLI_OVERWRITE="true"
make integration

@rene00 Was that before commander started executing the tests or during?

[Widcket]

Excellent, thanks for going the extra mile with this one.

[jfatta]

I'm wondering if this would only remove the apps created during the same tests execution, otherwise it might cause issues with other CI running at the same time.
thoughts?

[morganelle]

@jfatta if we have multiple integration tests on this tenant running at once, we'll want something smarter that deletes by client id. When we get CI running we'll also want to split out the test and cleanup steps so that the cleanup step is sure to run even if the tests fail.