Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform generate: check if email provider exists #857

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Sep 25, 2023

🔧 Changes

Adding a check to confirm that an email provider is configured for an Auth0 tenant before attempting to generate its configuration via the auth0 tf generate command. Otherwise, during the terraform plan or terraform apply, the following error will occur:

Error: Import block target does not exist
│ 
│   on auth0_import.tf line 5:
│    5: import {

🔬 Testing

Added unit tests and manually verified.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner September 25, 2023 20:00
@willvedd willvedd enabled auto-merge (squash) September 25, 2023 20:01
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c2826ae) 73.36% compared to head (2b4fa06) 73.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
+ Coverage   73.36%   73.38%   +0.01%     
==========================================
  Files          92       92              
  Lines       11876    11883       +7     
==========================================
+ Hits         8713     8720       +7     
  Misses       2647     2647              
  Partials      516      516              
Files Coverage Δ
internal/auth/scopes.go 100.00% <ø> (ø)
internal/auth0/auth0.go 100.00% <100.00%> (ø)
internal/cli/terraform.go 87.17% <100.00%> (ø)
internal/cli/terraform_fetcher.go 98.08% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willvedd willvedd merged commit 0e0c0a2 into main Sep 26, 2023
6 checks passed
@willvedd willvedd deleted the ESD-31285-tf-generate-check-email-provider-exists branch September 26, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants