DXCDT-595: Add ability to update signing alg for apis #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
DXCDT-595-alg-apis
branch
from
254ad22 to
2d2b88b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
==========================================
- Coverage 72.33% 72.31% -0.03%
==========================================
Files 92 92
Lines 12484 12500 +16
==========================================
+ Hits 9030 9039 +9
- Misses 2924 2930 +6
- Partials 530 531 +1 ☔ View full report in Codecov by Sentry. |
willvedd
reviewed
Nov 29, 2023
internal/cli/apis.go
Outdated
| apiSigningAlgorithm = Flag{ | ||
| Name: "Signing Algorithm", | ||
| LongForm: "signing-alg", | ||
| ShortForm: "a", |
There was a problem hiding this comment.
Can we remove the short arg? a isn't immediately clear about what it associates with. Further, users could get confused with -s, is it signing alg or scopes?
willvedd
approved these changes
Nov 30, 2023
m3talsmith
pushed a commit
to m3talsmith/auth0-cli
that referenced
this pull request
Dec 1, 2023
* Add ability to update signing alg for apis * Removing short alias --------- Co-authored-by: Will Vedder <will.vedder@okta.com>
m3talsmith
pushed a commit
that referenced
this pull request
Dec 5, 2023
* Bump github.com/auth0/go-auth0 from 1.2.0 to 1.3.0 (#908) Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0. - [Release notes](https://github.com/auth0/go-auth0/releases) - [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md) - [Commits](auth0/go-auth0@v1.2.0...v1.3.0) --- updated-dependencies: - dependency-name: github.com/auth0/go-auth0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * dxcdt-615-goreleaser-upgrade (#909) * Fix: Remove or replace deprecations for GoReleaser config Remove deprecated replacements Replace deprecated brews tap Replace deprecated scoop entries Fix name_template to reflect exact current naming conventions * DXCDT-582: Convert audience into a drop down in interactive mode in test token cmd (#906) Convert audience into a drop down in interactive mode in test token cmd * Bump github.com/auth0/go-auth0 from 1.2.0 to 1.3.0 (#908) Bumps [github.com/auth0/go-auth0](https://github.com/auth0/go-auth0) from 1.2.0 to 1.3.0. - [Release notes](https://github.com/auth0/go-auth0/releases) - [Changelog](https://github.com/auth0/go-auth0/blob/main/CHANGELOG.md) - [Commits](auth0/go-auth0@v1.2.0...v1.3.0) --- updated-dependencies: - dependency-name: github.com/auth0/go-auth0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * DXCDT-582: Convert audience into a drop down in interactive mode in test token cmd (#906) Convert audience into a drop down in interactive mode in test token cmd Title Os for final release name fit * Added batch deletes to actions * Add batch deletions Added batch deletion to actions command Added batch deletion to apis command Added batch deletion to apps command Added batch deletion to custom domains command Added batch deletion to log streams command Added batch deletion for organizations command Added batch deletion for roles command Added batch deletion for rules command Added batch deletion for users non-interactive command Added batch deletion for user blocks non-interactive command Update required golang minimum version * DXCDT-595: Add ability to update signing alg for apis (#926) * Add ability to update signing alg for apis * Removing short alias --------- Co-authored-by: Will Vedder <will.vedder@okta.com> * Bump github.com/auth0/go-auth0 from 1.3.0 to 1.3.1 (#929) * Updated docs * Simplify args loops * Updates for code review Ensure valid id before deletion process Normalize messages for deletion Remove unnecessary path escapes Continue on read failure instead of attempting delete Inform user of failed id on batch deletion Only document at most two ids likely * Validate input for askMultiSelect * Update docs * Remove unused variable * Use Batch deletion for integration test cleanup * Check to see if the tenant id is contained in the ids * Remove unused ids variable in warning * Fix print typo --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com> Co-authored-by: Will Vedder <will.vedder@okta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Adds ability to update signing alg for apis
📚 References
🔬 Testing
📝 Checklist