Add popup timeout config #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2019
|
Looks great to me. |
lbalmaceda
suggested changes
Aug 6, 2019
| /** | ||
| * We need to run the timers after we start `runPopup`, but we also | ||
| * need to use `jest.useFakeTimers` to trigger the timeout. | ||
| * That's why we're using a real `setTimeout`, then using fake timers |
luisrudge
force-pushed
the
feature/popup-config
branch
from
7403102 to
ee7318b
Compare
lbalmaceda
suggested changes
Aug 7, 2019
lbalmaceda
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #92
Description
Adds a config object to send popup configuration options. For now, only
timeoutInSecondsis available.References
#92
Testing