Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSR errors with fetch polyfill usage #184

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Fix SSR errors with fetch polyfill usage #184

merged 1 commit into from
Aug 28, 2019

Conversation

luisrudge
Copy link
Contributor

Description

The fetch polyfill was trying to access self directly and this breaks Server Rendered apps. This PR changes the usage of the unfetch library to not polyfill the global fetch property. Instead, it only requires and uses it when needed.

References

fix #181

Testing

  • [ x] This change adds test coverage for new/changed/fixed functionality

@luisrudge luisrudge added the tiny label Aug 28, 2019
@luisrudge luisrudge requested a review from a team August 28, 2019 14:36
@luisrudge luisrudge merged commit e7ed091 into master Aug 28, 2019
@stevehobbsdev stevehobbsdev deleted the fix/fetch-polyfill branch December 13, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with Razzle.JS / Auth0 integration
3 participants
@luisrudge @damieng @joshcanhelp