Fix incorrect state extraction from query string #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
reviewed
Sep 2, 2019
damieng
reviewed
Sep 2, 2019
damieng
previously approved these changes
Sep 2, 2019
damieng
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CLIs that are aggressively trying to minify our already minified code (like vue-cli and ng-cli) are causing issues with one of our dependencies (
qss).What happens is that the second minification pass modifies the content or our dependency making it run a different function.
Because of this bug, when our code tries to get the query string from the URL, it doesn't find the
stateparam and fails.This PR removes
qssas dependency and just encodes/decodes query strings manually.qssis still used as a dev dependency for integration tests.References
Fix #186
Testing
No test change because we were already testing the result of the parsed/encoded results.