Fix safari10 initialization error #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
reviewed
Oct 2, 2019
damieng
suggested changes
Oct 2, 2019
There was a problem hiding this comment.
Should only use webkitSubtle when subtle is not available. Not prefer webkitSubtle over subtle. Guidance from https://webkit.org/blog/7790/update-on-web-cryptography/
|
@damieng updated 🎉 thanks for the reference |
damieng
reviewed
Oct 9, 2019
src/index.ts
Outdated
| @@ -20,10 +21,14 @@ export default async function createAuth0Client(options: Auth0ClientOptions) { | |||
| 'For security reasons, `window.crypto` is required to run `auth0-spa-js`.' | |||
| ); | |||
| } | |||
| // safari 10 compat | |||
| if (!window.crypto.subtle && (<any>window.crypto).webkitSubtle) { | |||
| (<any>window.crypto).subtle = (<any>window.crypto).webkitSubtle; | |||
There was a problem hiding this comment.
No non-Auth0 code can be running in the Window while we're doing this right?
Trying to decide if replacing a global is safe in this context or whether we should be creating our own variable to use instead to avoid non-Auth0 code getting confused.
damieng
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Safari 10 uses
crypto.webkitSubtleinstead ofcrypto.subtle. This PR normalizes this behavior.References
ESD-2220
Testing