Include typescript exports #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeleusin
changed the title
felipeleusin
force-pushed
the
typescript_exports
branch
from
11f8348
to
51fc819
Compare
felipeleusin
force-pushed
the
typescript_exports
branch
from
51fc819
to
2f32078
Compare
|
@felipeleusin thanks for the PR 🎉 can you please check why integration tests are failing? I assume it's related to how the imports work? |
|
@felipeleusin - Are you able to take a look at the failing tests here? Thank you in advance 🙇 |
|
Hi sorry, still couldn't but I will be able to take a look at this next week |
|
Hi, just wanted to say that I'm switching jobs and won't be working with this library anymore so if anyone feels like picking this up, feel free |
stevehobbsdev
requested review from
stevehobbsdev
and removed request for
luisrudge
Closed
|
Closing this in favour of #310 |
|
Thanks for picking this up. Sorry I couldn't finish the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the exports of the typescript typings from the index.d.ts file. With this you can access all the typings directly from the package.
For example:
One downside is that you need to access the exported types directly inside the project but this is something I consider a acceptable and provides more clarity as to where the types are coming from.
I also renamed
getIdTokenClaimsOptionstoGetIdTokenClaimsOptionsbut kept an export with the old name for compatibility sake so this doesn't need to qualify as breaking change.References
Issues: #63, #39