Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-1634] Pass custom options to the token endpoint #465

Merged
merged 6 commits into from
May 19, 2020

Conversation

stevehobbsdev
Copy link
Contributor

Description

This fixes the ability to send custom options when using getTokenSilently in conjunction with using refresh tokens.

When using custom parameters with getTokenSilently, these custom options are now sent to both the authorize endpoint in the query string and the token endpoint in the request body (when not using refresh tokens), and to the token endpoint only, when using refresh tokens.

These custom parameters can then be picked up in a custom Rule.

This functionality appeared to work in when not using refresh tokens, as you could pass custom options and they would be sent, but only to the authorize endpoint.

References

Fixes #448

Testing

Added test coverage, also tested manually using the playground.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@stevehobbsdev stevehobbsdev added small CH: Fixed PR is fixing a bug labels May 15, 2020
@stevehobbsdev stevehobbsdev added this to the vNext milestone May 15, 2020
@stevehobbsdev stevehobbsdev requested a review from a team May 15, 2020 17:13
@adamjmcgrath adamjmcgrath self-assigned this May 18, 2020
src/Auth0Client.ts Show resolved Hide resolved
src/Auth0Client.ts Show resolved Hide resolved
src/Auth0Client.ts Show resolved Hide resolved
@stevehobbsdev stevehobbsdev merged commit 3f279a4 into master May 19, 2020
@stevehobbsdev stevehobbsdev deleted the fix/token-endpoint branch May 19, 2020 14:21
@picosam
Copy link
Contributor

picosam commented May 25, 2020

Hello @stevehobbsdev -- I do appreciate your reactivity on this ticket, thank you!
Any idea when it will be released?

@stevehobbsdev
Copy link
Contributor Author

Cutting the release now @picosam, expect it today at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sending additional query params on a refresh token request
3 participants