Allow redirect_uri override in loginWithRedirect #66
Conversation
| response_mode: 'query', | ||
| state: TEST_ENCODED_STATE, | ||
| nonce: TEST_RANDOM_STRING, | ||
| redirect_uri: REDIRECT_OPTIONS.redirect_uri, |
There was a problem hiding this comment.
shouldn't this be redirect_uri: redirect_uri ?
There was a problem hiding this comment.
@lbalmaceda I don't think so. The test determines that the options passed into loginWithRedirect take precedence over the options passed when creating the client. redirect_uri here represents the options passed into the client.
| @@ -111,7 +111,7 @@ export default class Auth0Client { | |||
| stateIn, | |||
| nonceIn, | |||
| code_challenge, | |||
| window.location.origin | |||
| this.options.redirect_uri || window.location.origin | |||
There was a problem hiding this comment.
default redirect_uri was window.location.origin?
There was a problem hiding this comment.
just for web_message requests (that don't actually redirect anywhere)
| @@ -64,7 +64,7 @@ export default class Auth0Client { | |||
| response_mode: 'query', | |||
| state, | |||
| nonce, | |||
| redirect_uri: this.options.redirect_uri || redirect_uri, | |||
| redirect_uri: redirect_uri || this.options.redirect_uri, | |||
There was a problem hiding this comment.
why was this flipped? where do this.options comes from?
There was a problem hiding this comment.
@lbalmaceda This is ultimately what was causing the bug. The options passed into createAuth0Client (this.options) was taking precedence over the options being passed into loginWithPopup, getTokenSilently, etc. It should be the other way around.
Description
The developer should be able to override the default redirect_uri when calling
loginWithRedirect. Today, we were actually overriding anything passed in theloginWithRedirectmethod with the default redirect_uri provided in thecreateAuth0Clientfunction, which doesn't make sense and it's a bug. This PR fixes that.References
Bug found in this thread: #52 (comment)
Testing