Failed tests in master branch

[fetis]

Otherwise, create a new issue with the following information:

• Code snippet or sample project that reproduces the bug
  I'm on the master branch and execute yarn test. I get 3 (sometimes 4) failed test, is it normal or I missed something in dev configuration?

347 passing (9s)
  3 failing

  1) helpers iframeHandler with context should destroy and callback with valid data if an event is valid:
     Uncaught Error: expected { eventListeners: { load: [], message: [] },
  emitEvent: [Function],
  addEventListener: [Function],
  removeEventListener: [Function],
  assimilate: [Function],
  id: 'the_iframe',
  style: { display: 'none' },
  src: undefined } to equal { eventListeners: { load: [], message: [] },
  emitEvent: [Function],
  addEventListener: [Function],
  removeEventListener: [Function],
  assimilate: [Function],
  id: 'the_iframe',
  style: { display: 'none' },
  src: undefined }
      at Assertion.assert (node_modules/expect.js/expect.js:99:13)
      at Assertion.be.Assertion.equal (node_modules/expect.js/expect.js:200:10)
      at Assertion.(anonymous function) [as be] (node_modules/expect.js/expect.js:73:24)
      at Object.removeChild (test/helper/iframe-handler.test.js:91:26)
      at Timeout._onTimeout (src/helper/iframe-handler.js:90:27)

  2) helpers iframeHandler with context should destroy and callback if a timeout occurs:
     Uncaught Error: expected 1 to equal 0
      at Assertion.assert (node_modules/expect.js/expect.js:99:13)
      at Assertion.be.Assertion.equal (node_modules/expect.js/expect.js:200:10)
      at Assertion.(anonymous function) [as be] (node_modules/expect.js/expect.js:73:24)
      at Timeout._onTimeout (test/helper/iframe-handler.test.js:286:78)
      at _combinedTickCallback (internal/process/next_tick.js:135:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

  3) helpers iframeHandler with context should throw an exception if an invalid eventListernerType is specified:
     TypeError: Attempted to wrap getWindow which is already wrapped
      at checkWrappedMethod (node_modules/sinon/lib/sinon/util/core.js:81:29)
      at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:129:21)
      at stub (node_modules/sinon/lib/sinon/stub.js:67:26)
      at stubWindow (test/helper/iframe-handler.test.js:104:3)
      at Context.<anonymous> (test/helper/iframe-handler.test.js:348:20)
  --------------
  Error: Stack Trace for original
      at Object.wrapMethod (node_modules/sinon/lib/sinon/util/core.js:154:34)
      at stub (node_modules/sinon/lib/sinon/stub.js:67:26)
      at stubWindow (test/helper/iframe-handler.test.js:104:3)
      at Context.<anonymous> (test/helper/iframe-handler.test.js:348:20)

• Auth0.js version 9.6.0
• Browser & OS: Node: 8.9.4, macOS 10.13.4 (17E202), yarn 1.7.0

In general, the test environment is very unstable. With yarn test:watch I get 372 passed and fail after timeout OR 90 passed/2 failed and timeout at the end

[luisrudge]

You just have to re-run them. They're very unreliable right now :(

[fetis]

May we keep this open? I think it's connected with #764 because manipulation with global.window in one test may produce side effects for others. I can look into it afterward.

[luisrudge]

You want to fix the unreliability? I know for a fact that these tests fails from time to time because they fail in my machine and in CI as well.

[fetis]

I can look into this. I'm quite sure it's connected to this window issue.

btw, what is your node.js environment for CI, can I use ES6 features in tests?

[luisrudge]

Ok. if you find anything, just open another PR so I can review. Let's keep the issue closed to keep so it doesn't pollute the issues tab.
I'm pretty sure you can write ES6, but we're not using it now for tests yet. I want to convert all tests in one go so we don't have mixed stuff.