Remove global from window helpers #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetis
changed the title
|
Thanks for the PR. Do you know why this line lost coverage? https://codecov.io/gh/auth0/auth0.js/compare/5a531f5013e77b0185e645954e5b505ab61b16db...2966805bd0100ede52a9aef1e81dd21ba5347d68/changes |
|
I assume it's because of this change https://github.com/auth0/auth0.js/pull/764/files#diff-fa3d40d414115b7a8cf9ef99f7282b22R173, which I took as someone accidentally duplicated the line.s But I think it should be restored in a more explicit way, because popup_handler may return the current instance |
|
ahaha, yeah.. good catch! That's probably it, considering it's testing |
|
I've fixed it. Should go back to normal now. |
luisrudge
approved these changes
Jun 7, 2018
|
Thanks for the PR! 🎉 |
bors bot
referenced
this pull request
in mozilla/delivery-console
Jun 7, 2018
183: Update dependency auth0-js to v9.6.1 r=rehandalal a=renovate[bot] This Pull Request updates dependency [auth0-js](https://github.com/auth0/auth0.js) from `v9.6.0` to `v9.6.1` <details> <summary>Release Notes</summary> ### [`v9.6.1`](https://github.com/auth0/auth0.js/blob/master/CHANGELOG.md#v961httpsgithubcomauth0auth0jstreev961-2018-06-07) [Compare Source](auth0/auth0.js@v9.6.0...v9.6.1) [Full Changelog](auth0/auth0.js@v9.6.0...v9.6.1) **Fixed** - Remove global from window helpers [\#​764](`https://github.com/auth0/auth0.js/pull/764`) ([fetis]) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
|
thanks for merge |
|
This was already released in 9.6.1 🎉 |
kmaida
added a commit
to kmaida/blog
that referenced
this pull request
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
globalfrom window helpers to make it Angular 6 compatible.globalin the future (it does it automatically when encounters this variable).I left current testing approach intact (manually mock
windowobject). I think in the future it can be replaced with JSDOM or similar implementationRelated issues #759 #755 #754 #753 #748