[SDK-974] Improved OIDC compliance #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
requested review from
joshcanhelp
and removed request for
a team
joshcanhelp
approved these changes
Dec 10, 2019
| if ( | ||
| validationError.error !== 'invalid_token' || | ||
| validationError.errorDescription === 'Nonce does not match.' | ||
| (validationError.errorDescription && |
There was a problem hiding this comment.
Consider breaking this logic out into a variable for more clarity.
Also ... why are we checking the description as well if we hav an error code for this?
There was a problem hiding this comment.
This just modifies existing logic rather than rewriting it. We do have an error code but it's the same error code for every error. I don't think the check here is terrible, but it could be refactored later if desired.
| @@ -414,7 +437,8 @@ WebAuth.prototype.validateToken = function(token, nonce, cb) { | |||
| jwksURI: this.baseOptions.jwksURI, | |||
| audience: this.baseOptions.clientID, | |||
| leeway: this.baseOptions.leeway || 0, | |||
| __disableExpirationCheck: this.baseOptions.__disableExpirationCheck | |||
peterblazejewicz
added a commit
to peterblazejewicz/DefinitelyTyped
that referenced
this pull request
Jan 13, 2020
Newly documented creation option: auth0/auth0.js#1059 https://github.com/auth0/auth0.js/#initialize Thanks!
5 tasks
elibarzilay
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jan 15, 2020
Newly documented creation option: auth0/auth0.js#1059 https://github.com/auth0/auth0.js/#initialize Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
idtoken-verifierto2.0.0for [SDK-974] Improved OIDC compliance idtoken-verifier#77__disableExpirationCheck, which has now been removed fromidtoken-verifierTesting
Unit tests were updated, tested manually in Chrome + IE11 to see that the ID token validation checks still passed at runtime.
Checklist