Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: changed the trigger from pull_request_target to pull_request for better security #1463

Merged
merged 2 commits into from
Sep 3, 2024
Merged

ci: changed the trigger from pull_request_target to pull_request for better security #1463

merged 2 commits into from
Sep 3, 2024

Conversation

desusai7
Copy link
Contributor

@desusai7 desusai7 commented Aug 30, 2024 •
edited
Loading

ci: changed the trigger from pull_request_target to pull_request for better security

Checklist

@desusai7 desusai7 requested a review from a team as a code owner August 30, 2024 06:47
@desusai7 desusai7 self-assigned this Aug 30, 2024
poovamraj
poovamraj previously approved these changes Aug 30, 2024
View reviewed changes
mpast
mpast reviewed Aug 30, 2024
View reviewed changes
Copy link

@mpast mpast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks team! 👍

@desusai7 desusai7 changed the title ci: changed browserstack workflow to check for author of the PR instead of actor ci: changed the trigger from pull_request_target to pull_request for better security Aug 30, 2024
@desusai7 desusai7 requested review from poovamraj and mpast August 30, 2024 11:56
@desusai7 desusai7 enabled auto-merge September 3, 2024 05:09
@desusai7 desusai7 merged commit 231307b into master Sep 3, 2024
15 checks passed
@desusai7 desusai7 deleted the security/ci/browserstack_workflow branch September 3, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duedares-rvj duedares-rvj duedares-rvj approved these changes

@mpast mpast mpast approved these changes

@poovamraj poovamraj Awaiting requested review from poovamraj

Assignees

@desusai7 desusai7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@desusai7 @mpast @duedares-rvj @poovamraj