Use CookieStorage when accessing localStorage throws an error #698
Conversation
| @@ -201,7 +201,7 @@ <h2>Console:</h2> | |||
|
|
|||
| var webAuth = new auth0.WebAuth({ | |||
| domain: 'brucke.auth0.com', | |||
| redirectUri: 'https://localhost:3000/example', | |||
| redirectUri: 'https://localhost:3000/example/', | |||
There was a problem hiding this comment.
I was trying it in safari and it doesn't accept the #access_token if you don't have a / in the end 🤦♂️
There was a problem hiding this comment.
Have you tested in other browsers to make sure this addition doesn't do something silly with this addition?
There was a problem hiding this comment.
chrome/safari/firefox. here's the thing: we already have code that handles when you can't read/write from the storage, the issue was that safari specifically was throwing an exception even before that (just by referencing localSTorage).
| @@ -5,7 +5,14 @@ var Warn = require('../warn'); | |||
|
|
|||
| function StorageHandler() { | |||
| this.warn = new Warn({}); | |||
| this.storage = windowHandler.getWindow().localStorage || new CookieStorage(); | |||
There was a problem hiding this comment.
The PR name is use cookiestorage when local not available. It already did this though? This is a fix to catch errors no?
luisrudge
changed the title
src/helper/storage/handler.js
Outdated
| // when localStorage is disabled. | ||
| this.storage = windowHandler.getWindow().localStorage; | ||
| } catch (e) { | ||
| this.warn.warning("Can't use localStorage. Using CookieStorage instead."); |
There was a problem hiding this comment.
Maybe you want to add the e to the log?
some browsers throw an error when trying to access localStorage when localStorage is not available