Add jwksURI override option #717
Conversation
| __tenant: { type: 'string', message: '__tenant option is required' }, | ||
| __token_issuer: { type: 'string', message: '__token_issuer option is required' } | ||
| __tenant: { optional: true, type: 'string', message: '__tenant option is required' }, | ||
| __token_issuer: { |
There was a problem hiding this comment.
have you run the beautifier here? the others are one liners while this one is split in 3 lines.
There was a problem hiding this comment.
nope. I'm not testing idtoken-verifier internals here.
There was a problem hiding this comment.
yes, it's the automatic code formatter
There was a problem hiding this comment.
I'm not testing idtoken-verifier internals here.
This looks internal to me. So if you're already doing it to check if a value gets replaced, do the same to check that a value remains as expected 👍
There was a problem hiding this comment.
idtoken-verifier doesn't set the url in the constructor, it builds later on. I added a test to make sure it's undefined if you don't overwrite.
There was a problem hiding this comment.
Then in that case both tests should ignore the idtoken-verifier implementation and test the actual outcome:
- Have a test that succeeds to verify a token using a custom
jwks_uri. - Have a test that succeeds to verify a token using the default
jwks_uri(${id_token.iss}/.well-known/jwks.json).
Probably you can manage to feed a jwks file to the library. If you don't test this this way, how can you be sure that the __jwks_uri override is actually affecting the library verifying outcome?
ZD:37454