Fixed transaction state not being set to expire in 30 minutes #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passed `expires` option does not override the default value. I'd like to ask is it okay to store nonce for 30 mins? IMO, a very short time around 5 mins is enough.
luisrudge
suggested changes
Oct 5, 2018
|
This has been introduced since |
luisrudge
approved these changes
Oct 6, 2018
luisrudge
changed the title
|
Thanks so much for the PR 🎉 We remove the transaction state once the authentication is successful. But we can't remove if the authentication fails for any reason, because we don't get a |
|
@luisrudge Can we have patch release for this? |
|
@sayuti-daniel we'll have a new release in 2 days |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed
expiresoption does not override the default value.I'd like to ask is it okay to store nonce for 30 mins? IMO, a very short time around 5 mins is enough.