Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DXCDT-354: Enhance ADFS Connection Options #161

Merged
merged 2 commits into from
Jan 30, 2023
Merged

DXCDT-354: Enhance ADFS Connection Options #161

merged 2 commits into from
Jan 30, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jan 30, 2023 •
edited
Loading

🔧 Changes

In this PR we are adding a couple of missed options for the ADFS Connection type:

  • FedMetadataXML
  • Thumbprints
  • SignInEndpoint
  • TrustEmailVerified

📚 References

🔬 Testing

Tests are added as well.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught marked this pull request as ready for review January 30, 2023 17:33
@sergiught sergiught requested a review from a team as a code owner January 30, 2023 17:33
@sergiught sergiught mentioned this pull request Jan 30, 2023
Merged
2 tasks
Base automatically changed from patch/DXCDT-353-adfs to main January 30, 2023 17:50
@sergiught sergiught merged commit fc2fb9a into main Jan 30, 2023
@sergiught sergiught deleted the patch/DXCDT-354-adfs-metadata-xml branch January 30, 2023 17:51
@sergiught sergiught mentioned this pull request Jan 30, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiught @Widcket