Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-4558] Add passkey metadata in authentication method and connections #296

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

ewanharris
Copy link
Contributor

🔧 Changes

Adds passkey metadata to Connection and AuthenticationMethod structs

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ewanharris ewanharris requested a review from a team as a code owner October 23, 2023 09:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fad453) 94.76% compared to head (6343b55) 94.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   94.76%   94.80%   +0.04%     
==========================================
  Files          46       46              
  Lines        8837     8910      +73     
==========================================
+ Hits         8374     8447      +73     
  Misses        361      361              
  Partials      102      102              
Files Coverage Δ
management/connection.go 72.50% <ø> (ø)
management/management.gen.go 100.00% <100.00%> (ø)
management/user.go 84.65% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

management/connection.go Outdated Show resolved Hide resolved
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
@ewanharris ewanharris requested a review from Widcket October 24, 2023 10:13
@ewanharris ewanharris merged commit 69d8284 into main Oct 24, 2023
4 checks passed
@ewanharris ewanharris deleted the feat/SDK-4558 branch October 24, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants