Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DXCDT-175] Add read and update to Duo Settings #84

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jul 3, 2022

Description

This PR adds support to update settings on Duo, needed for auth0/terraform-provider-auth0#165.

References

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have read and agreed to the terms within the Auth0 Code of Conduct.
  • I have read the Auth0 General Contribution Guidelines.
  • I have reviewed my own code beforehand.
  • I have added documentation for new/changed functionality in this PR.
  • All active GitHub checks for tests, formatting, and security are passing.
  • The correct base branch is being used, if not main.

@sergiught sergiught changed the base branch from main to feature/DXCDT-175-guardian++-part1 July 3, 2022 11:46
@codecov-commenter
Copy link

Codecov Report

Merging #84 (8b11307) into feature/DXCDT-175-guardian++-part1 (b5ac609) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@                          Coverage Diff                           @@
##           feature/DXCDT-175-guardian++-part1      #84      +/-   ##
======================================================================
+ Coverage                               94.62%   94.64%   +0.02%     
======================================================================
  Files                                      33       33              
  Lines                                    5582     5604      +22     
======================================================================
+ Hits                                     5282     5304      +22     
  Misses                                    240      240              
  Partials                                   60       60              
Impacted Files Coverage Δ
management/guardian.go 92.43% <100.00%> (+0.33%) ⬆️
management/management.gen.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ac609...8b11307. Read the comment docs.

@sergiught sergiught self-assigned this Jul 3, 2022
@sergiught sergiught marked this pull request as ready for review July 3, 2022 11:48
@sergiught sergiught requested a review from a team as a code owner July 3, 2022 11:48
Base automatically changed from feature/DXCDT-175-guardian++-part1 to main July 5, 2022 21:50
@sergiught sergiught merged commit 66d2c9c into main Jul 5, 2022
@sergiught sergiught deleted the feature/DXCDT-175-guardian++-part2 branch July 5, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants