Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TypeScript typings #122

Merged
merged 6 commits into from
Jun 18, 2021
Merged

Conversation

ItalyPaleAle
Copy link
Contributor

Changes

This PR adds TypeScript definitions for the library. This was auto-generated from JSDoc, but with some manual fixes applied.

Testing

N/A

Checklist

@ItalyPaleAle ItalyPaleAle requested a review from a team as a code owner May 5, 2021 03:46
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution! Just a couple of changes needed.

types/index.d.ts Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
@ItalyPaleAle ItalyPaleAle dismissed a stale review via 622d69e June 10, 2021 04:10
@ItalyPaleAle
Copy link
Contributor Author

@stevehobbsdev Sorry for the delay. Updates as requested

@fnagel
Copy link

fnagel commented Jun 15, 2021

@stevehobbsdev Any chance to get this merged soon? :-)

@stevehobbsdev stevehobbsdev self-requested a review June 16, 2021 09:21
@stevehobbsdev
Copy link
Contributor

@fnagel Yes - let me put out a release this week 👍🏻

@fnagel
Copy link

fnagel commented Jun 17, 2021

@stevehobbsdev Wonderful :-) Thanks a lot!

@stevehobbsdev stevehobbsdev added this to the v2.2.0 milestone Jun 18, 2021
@stevehobbsdev stevehobbsdev merged commit 7ee8863 into auth0:master Jun 18, 2021
@stevehobbsdev stevehobbsdev mentioned this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants