Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the javadocs to include the default caching behaviour. #179

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Updating the javadocs to include the default caching behaviour. #179

merged 2 commits into from
Jul 28, 2023

Conversation

msailes
Copy link
Contributor

@msailes msailes commented Jun 19, 2023

Changes

I've update the Javadocs for

jwks-rsa-java/src/main/java/com/auth0/jwk/JwkProviderBuilder.java

Line 76 in 7eb15a2

public JwkProviderBuilder cached(boolean cached) {

To better describe the default caching behaviour when you don't specify the cache size and / or the timeout duration.

Checklist

@msailes msailes requested a review from a team as a code owner June 19, 2023 11:09
jimmyjames
jimmyjames approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jimmyjames jimmyjames merged commit 8da6f90 into auth0:master Jul 28, 2023
5 checks passed
@jimmyjames jimmyjames mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msailes @jimmyjames