Expose getAll() publicly on UrlJwkProvider #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This together with #36 would be very useful for our current project. |
|
it's 2019, any chance to get this reviewed this year? :) |
|
@lbalmaceda ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational
We have a service that has few users but gets updated often.
This leads to problems with the existing Guava cache provider as users experience cache misses on a regular basis when trying to authenticate. As the Guava cache offloads cache loading to the user request, this leads to poor user experience (slow requests).
Exposing the getAll() function publicly on the JWK provider will allow us to build smarter caches that asynchronously poll all JWKs without offloading the work to the user session.
We expect this will improve usability.