Concatenate JWKS path with existing path on domain if present #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current jwks url provider implementation any path on domain will be replaced by the "well known" jwks path. This will likely work for most providers, but some (e.g. AWS Cognito) uses a unique resource path on a shared endpoint to identify the issuer ie.
https://cognito-idp.ap-southeast-2.amazonaws.com/ap-southeast-2_example
I'm aware this might have been a deliberate decision given that there is a unit test to verify this behavior. However, I think allowing for a more flexible approach will benefit this library since it's being actively used in other projects such as ktor
Changes
References
Please include relevant links supporting this change such as a:
Testing
Checklist