FDR-297: Adding okta for enterprise #2172
Conversation
| @@ -9,7 +9,7 @@ import { authButtonsTheme } from '../../connection/social/index'; | |||
|
|
|||
| // TODO: handle this from CSS | |||
| function icon(strategy) { | |||
| if (strategy === 'google-apps') return strategy; | |||
| if (strategy === 'google-apps' || strategy === 'okta') return strategy; | |||
There was a problem hiding this comment.
I am assuming this is for enterprise? The other enterprise connections only return the 'auth0' icon (including PingFederate).
There was a problem hiding this comment.
Yea, this is for enterprise. I was slightly confused by this section, so hoping @auth0/dx-sdks-engineer can clarify if this is necessary
There was a problem hiding this comment.
Just for my understanding - This means the avatar/icon only displays for Okta and Google right? And the other if is for microsoft and everything else displays default auth0 button?
There was a problem hiding this comment.
That's correct. I'm unaware as to the history as to why it's like that though.
jamescgarrett
dismissed stale reviews from stevehobbsdev, albertburchi-okta, and adrian-prananda
via
cb971ed
|
@stevehobbsdev - Is something wrong with the BrowserStack test? |
|
@jamescgarrett The BrowserStack tests won't run successfully as this PR has been created from a fork. Our CI configuration prevents secrets from being available when building forks and so the BS tests won't be able to authenticate with BS. I've verified them on my own machine against BS and we're all good. |
Changes
oktato the enterprise strategy list.oktaoktaHDR (default enterprise flow):
Quick Auth:
References
https://auth0team.atlassian.net/browse/FDR-297
Testing
Checklist