Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix yarn lockfile with yarn@1 #2244

Merged
merged 1 commit into from
Jan 20, 2023
Merged

chore: fix yarn lockfile with yarn@1 #2244

merged 1 commit into from
Jan 20, 2023

Conversation

stevehobbsdev
Copy link
Contributor

I had to regenerate the lockfile using Yarn@1 (the last build failed and was using v3); to rule out an incompatibility with the versions, I just regenerated it with the same version that CI is using.

@stevehobbsdev stevehobbsdev requested a review from a team as a code owner January 20, 2023 19:53
@Widcket
Copy link
Contributor

Widcket commented Jan 20, 2023

CI is failing.

evansims
evansims approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure is safe to ignore; Snyk bug. I'll give it a kick on our end after force merge.

@stevehobbsdev stevehobbsdev merged commit 54e4a2d into master Jan 20, 2023
@stevehobbsdev stevehobbsdev deleted the chore/fix-yarn branch January 20, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansims evansims evansims approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevehobbsdev @Widcket @evansims