-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WelcomeMessage header text marked as heading #2373
Conversation
Thanks for the PR, can you elaborate which tool showed this as an a11y issue to try and understand what's happening and how a welcome message is treated as a heading? Thanks |
Hey, as outlined in rule 1.3.1.e Headings - Text that acts as a heading visually or structurally MUST be designated as a true heading in the markup. The Welcome message visually acts as the main element heading on the login screen. Providing a heading element will aid screen reader users to understand the structure of the content |
More info provided above |
Thanks for this change, looks legit and definetly want to look into adding this. Has this been tester with a certain screenreader? |
Thanks for your contribution here @piwysocki ! 🎉 |
Changes
role="heading" attribute and aria-level="1" attribute added to WelcomeMessage heading.
It adds heading semantics to markup without the risk of breaking any styles.
References
This change resolves an issue in accessibility.
Header name and title appears to be heading for section of content, but is not marked as heading for screen reader users.
Testing
Checklist