security: updating semver to 7.5.4 to resolve CVE-2022-25883 #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelacey2012
changed the title
david-renaud-okta
previously approved these changes
Aug 28, 2023
4 tasks
|
When will this PR be merged and a new version of the module published? |
cpettet
reviewed
Aug 28, 2023
package.json
Outdated
| @@ -39,7 +39,7 @@ | |||
| "jws": "^3.2.2", | |||
| "lodash": "^4.17.21", | |||
| "ms": "^2.1.1", | |||
| "semver": "^7.3.8" | |||
| "semver": "^7.5.2" | |||
There was a problem hiding this comment.
Suggested change
| "semver": "^7.5.2" | |
| "semver": "^7.5.4" |
jakelacey2012
changed the title
jakelacey2012
force-pushed
the
update/semver-7.5.2
branch
from
3f875e9
to
dc01c79
Compare
SEKERM
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
lgtm. @david-renaud-okta can you give approval with write access:
Review required
At least 1 approving review is required by reviewers with write access.
CharlesRea
approved these changes
Aug 29, 2023
|
@jakelacey2012 when will you merge into master? Thank you. |
This was referenced Aug 30, 2023
|
You could have just removed semver https://github.com/auth0/node-jsonwebtoken/pull/880/files D'oh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
This PR updates semver to a minimum version of 7.5.4 to resolve CVE-2022-25883.
References
Testing
npm testis passing.Checklist