Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy option to jwksClient #125

Merged
merged 5 commits into from
Feb 18, 2020
Merged

Conversation

benoitsepe
Copy link
Contributor

@benoitsepe benoitsepe commented Feb 13, 2020

Description

I added an optional parameter to jwksClient to be able to use the proxy of the request module, in order to fetch the JWKs keys through a proxy.

References

https://github.com/request/request#proxies

Testing

Run npm run test, I added a little test for the proxy. To manually test the package, you can create a client with a proxy, and run it

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@benoitsepe benoitsepe requested a review from a team February 13, 2020 17:12
@davidpatrick davidpatrick merged commit 31177e3 into auth0:master Feb 18, 2020
@davidpatrick davidpatrick added this to the 1.7.0 milestone Feb 18, 2020
@davidpatrick davidpatrick mentioned this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants