-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an alternative source for keysets #202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a user to provide an interceptor for providing keys before checking an endpoint. This will allow users to provide keys from env variables, local files, and temp cache in aws.
davidpatrick
changed the title
getKeysInterceptor
Provides an alternative source for keysets
Dec 3, 2020
adamjmcgrath
reviewed
Dec 3, 2020
adamjmcgrath
reviewed
Dec 3, 2020
adamjmcgrath
reviewed
Dec 3, 2020
adamjmcgrath
previously approved these changes
Dec 4, 2020
adamjmcgrath
reviewed
Dec 4, 2020
adamjmcgrath
approved these changes
Dec 4, 2020
davidpatrick
changed the title
Provides an alternative source for keysets
Provide an alternative source for keysets
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to replace #199 and addresses #201. The reason for closing #199, is that a custom cache looked to be the right solution until we started implementing it from the user standpoint. As it would require an async cache and ended up being a lot of heavy lifting for the user in order to address the issues referenced in #201.
The problem at hand we are trying to solve is allowing the user to provide an alternative source for keysets. With that in mind we should
References
Testing
Tests provided ✅
Checklist
master