Use hostname instead of host when creating request #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is common to host services on different ports during development / testing. I noticed a DNS failure when the jwks endpoint was served with a port. For example http://localhost:3000/oidc/jwks.
The fix is to use hostname instead of host when constructing the request.
You can see the difference between host and hostname in the scenarios below.
Testing
Call jwksRsa.passportJwtSecret using a jwksUri containing a port (e.g. http://localhost:3000). Notice the ENOTFOUND failure caused by dns resolution errors.
Checklist
master