android: allow root project to specify dependency versions #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This did the trick for me, after setting supportLibVersion in my root build.gradle's ext block. |
demoran23
approved these changes
Apr 23, 2018
lbalmaceda
previously approved these changes
Apr 24, 2018
@mlc @demoran23 should we add this notice somewhere in the Readme file?? |
|
Good idea, @lbalmaceda! I've updated the PR to include a note in the |
|
thanks! |
|
I'm stuck on this but have copied the gradle file from this PR — any update on when this will be published on NPM? |
|
@Amnesthesia Sorry about that 😞will be in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native projects with multiple native dependencies often end up unintentionally relying on a variety of Android SDK versions, which can lead to unpredictable build-time failures or even run-time crashes, such as the weirdness in #67. Many libraries (see, e.g., react-native-maps/react-native-maps#2047, invertase/react-native-firebase#1007) have been moving to a system of allowing the solution recommended by google of having the root project set properties with the desired dependency versions. This PR implements that solution for
react-native-auth0.