DXCDT-644: clean up of expand for SCIM

auth0 · Jul 18, 2024 · ea6dfd3 · ea6dfd3
1 parent fa7be65
commit ea6dfd3
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/internal/auth0/connection/expand.go b/internal/auth0/connection/expand.go
@@ -1083,10 +1083,11 @@ func checkForUnmanagedConfigurationSecrets(configFromTF, configFromAPI map[strin
 func expandSCIMConfigurationMapping(data *schema.ResourceData) *[]management.SCIMConfigurationMapping {
 	srcMapping := data.Get("mapping").(*schema.Set)
 	mapping := make([]management.SCIMConfigurationMapping, 0, srcMapping.Len())
-	for _, srcMap := range srcMapping.List() {
+	for _, item := range srcMapping.List() {
+		srcMap := item.(map[string]interface{})
 		mapping = append(mapping, management.SCIMConfigurationMapping{
-			Auth0: auth0.String(srcMap.(map[string]interface{})["auth0"].(string)),
-			SCIM:  auth0.String(srcMap.(map[string]interface{})["scim"].(string)),
+			Auth0: auth0.String(srcMap["auth0"].(string)),
+			SCIM:  auth0.String(srcMap["scim"].(string)),
 		})
 	}
 
@@ -1097,8 +1098,7 @@ func expandSCIMConfiguration(data *schema.ResourceData) *management.SCIMConfigur
 	cfg := data.GetRawConfig()
 	scimConfiguration := &management.SCIMConfiguration{}
 	if !cfg.GetAttr("user_id_attribute").IsNull() {
-		userIDAttribute := data.Get("user_id_attribute").(string)
-		scimConfiguration.UserIDAttribute = &userIDAttribute
+		scimConfiguration.UserIDAttribute = auth0.String(data.Get("user_id_attribute").(string))
 	}
 	if !cfg.GetAttr("mapping").IsNull() && cfg.GetAttr("mapping").AsValueSet().Length() > 0 {
 		scimConfiguration.Mapping = expandSCIMConfigurationMapping(data)