[1/3] [DXCDT-102] Prepare to upgrade terraform-plugin-sdk to v2 #121
Conversation
|
|
||
| require ( | ||
| github.com/auth0/go-auth0 v0.6.1 | ||
| github.com/hashicorp/go-multierror v1.1.1 | ||
| github.com/hashicorp/terraform-plugin-sdk v1.16.1 | ||
| ) | ||
|
|
||
| require ( |
There was a problem hiding this comment.
Please check https://go.dev/doc/go1.17#go-command for more details as to why these indirect deps are surfaced within the go.mod instead of keeping them only in the go.sum.
There was a problem hiding this comment.
Question (non-blocking): So if I read this correctly, since we're moving forward with Go 1.18 and presumably most of our dependencies do or will, we can expect this separate require block to always contain these indirect dependencies. Or posed another way, this isn't going away, right?
There was a problem hiding this comment.
That's correct, it's here to stay with us indefinitely.
| } | ||
| return 0 | ||
| } | ||
| } | ||
|
|
||
| func stringToHashCode(s string) int { |
There was a problem hiding this comment.
| @@ -1,36 +0,0 @@ | |||
| package debug | |||
There was a problem hiding this comment.
Never used anywhere, so we're cleaning it up so we don't need to upgrade this to sdk v2 as well.
sergiught
changed the title
sergiught
changed the title
sergiught
changed the title
Description
In this PR we're doing a couple of quick pre-steps in order for us to be able to upgrade to terraform-plugin-sdk@v2.
Terraform Upgrade Guide: https://www.terraform.io/plugin/sdkv2/guides/v2-upgrade-guide
Suggestions from https://www.terraform.io/plugin/sdkv2/guides/v2-upgrade-guide#removal-of-helper-hashcode-package as the hashcode pkg was removed.
Checklist
Note: Checklist required to be completed before a PR is considered to be reviewable.
Auth0 Code of Conduct
Auth0 General Contribution Guidelines
Changes include test coverage?
Does the description provide the correct amount of context?
Have you updated the documentation?
Is this code ready for production?