Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1/X] [DXCDT-175] Add support for webauthn in guardian resource #213

Merged
merged 2 commits into from
Jul 7, 2022
Merged

[1/X] [DXCDT-175] Add support for webauthn in guardian resource #213

merged 2 commits into from
Jul 7, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jul 2, 2022 •
edited
Loading

Description

Fixes partially: #165, more to follow after this PR. Depends on auth0/go-auth0#83.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@sergiught sergiught self-assigned this Jul 2, 2022
@sergiught sergiught force-pushed the feature/DXCDT-175-guardian++part1 branch from 1187bea to 963ed01 Compare July 2, 2022 23:48
@sergiught sergiught marked this pull request as ready for review July 2, 2022 23:49
@sergiught sergiught requested a review from a team as a code owner July 2, 2022 23:49
@sergiught sergiught marked this pull request as draft July 2, 2022 23:52
@sergiught sergiught force-pushed the feature/DXCDT-175-guardian++part1 branch from 963ed01 to 3caadaa Compare July 3, 2022 00:10
@sergiught sergiught marked this pull request as ready for review July 3, 2022 00:31
@sergiught sergiught changed the title [DXCDT-175] Add support for webauthn in guardian resource [1/X] [DXCDT-175] Add support for webauthn in guardian resource Jul 3, 2022
Widcket
Widcket reviewed Jul 4, 2022
View reviewed changes
go.sum Outdated Show resolved Hide resolved
Widcket
Widcket suggested changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a feature branch for multi-PR work.

@sergiught sergiught marked this pull request as draft July 5, 2022 13:08
@sergiught sergiught force-pushed the feature/DXCDT-175-guardian++part1 branch from 3caadaa to 2dd6f6a Compare July 6, 2022 13:37
@sergiught sergiught marked this pull request as ready for review July 6, 2022 13:45
@sergiught sergiught requested a review from Widcket July 6, 2022 13:45
@sergiught sergiught merged commit a011fe9 into main Jul 7, 2022
@sergiught sergiught deleted the feature/DXCDT-175-guardian++part1 branch July 7, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees

@sergiught sergiught

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiught @Widcket