Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_email_in_redirect field to email template resource #229

Merged
merged 8 commits into from
Jul 12, 2022

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jul 11, 2022

Description

Adding the include_email_in_redirect field for email template resources. Request for this came in via #34. This work necessitates a correlating Go SDK addition.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@willvedd willvedd requested a review from a team as a code owner July 11, 2022 17:12
@willvedd willvedd marked this pull request as draft July 11, 2022 17:14
@willvedd willvedd marked this pull request as ready for review July 12, 2022 14:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #229 (cc14e96) into main (7b53f6d) will increase coverage by 0.01%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   83.63%   83.65%   +0.01%     
==========================================
  Files          36       36              
  Lines        6587     6595       +8     
==========================================
+ Hits         5509     5517       +8     
  Misses        859      859              
  Partials      219      219              
Impacted Files Coverage Δ
auth0/resource_auth0_email_template.go 79.72% <94.73%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b53f6d...cc14e96. Read the comment docs.

@willvedd willvedd merged commit f98e2ae into main Jul 12, 2022
@willvedd willvedd deleted the add-include-email-in-redirect branch July 12, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants