[1/2] #35 Refactor user resource #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
changed the title
Widcket
reviewed
Jul 18, 2022
auth0/resource_auth0_user_test.go
Outdated
| @@ -234,31 +213,22 @@ resource auth0_user auth0_user_issue_218 { | |||
| } | |||
| ` | |||
|
|
|||
| func TestAccUserChangeUsername(t *testing.T) { | |||
| func TestAccUserIssue218(t *testing.T) { | |||
There was a problem hiding this comment.
Let's use a more descriptive name here.
sergiught
force-pushed
the
patch/fix-issue33-user_metadata
branch
from
82d87a1 to
4de639b
Compare
Widcket
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just some refactor on the user resource in preparation of fixing #35
Checklist
Note: Checklist required to be completed before a PR is considered to be reviewable.
Auth0 Code of Conduct
Auth0 General Contribution Guidelines
Changes include test coverage?
Does the description provide the correct amount of context?
Have you updated the documentation?
Is this code ready for production?